Skip to content

Conversation

@Harshdev098
Copy link

Have used tokio-listener, --listen-addr instead of --port in payjoin-directory as part of #941

Pull Request Checklist

Please confirm the following before requesting review:

@spacebear21
Copy link
Collaborator

Thanks for the contribution, however payjoin-directory is being deprecated in favor of the unified payjoin-service. We may revisit whether tokio-listener is worth adding as a dependency there, but I think a simple serde::Deserializer implementation for the port would be sufficient. I'm updating #941 now to make this clearer.

@Harshdev098
Copy link
Author

maybe factor out a tower_http OHTTP gateway middleware

@spacebear21 Can I take up this one now if it is on priority, or it should be worked after the merge of payjoin-directory and ohttp-relay?

Also, are there any priority issues you’d recommend I pick up?

@spacebear21
Copy link
Collaborator

I just ported this change to #941 and credited you as co-author on that commit 776943f. I'd appreciate a review on that PR and it may help you if you'd like to work on follow-up issues related to the directory/relay infrastructure!

Other than that there is a new tracking issue for FFI related gaps that could be good first issues #1264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants